[webkit-reviews] review granted: [Bug 107338] [chromium] support the lucid version of freetype on precise in DRT : [Attachment 189618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 15:52:29 PST 2013


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 107338: [chromium] support the lucid version of freetype on precise in DRT
https://bugs.webkit.org/show_bug.cgi?id=107338

Attachment 189618: Patch
https://bugs.webkit.org/attachment.cgi?id=189618&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189618&action=review


r=me with the third_party/freetype2 lines removed.

> Source/WebKit/chromium/DEPS:189
> +    'third_party/freetype2':
> +	 Var('chromium_svn')+'/third_party/freetype2@'+Var('chromium_rev'),

I don't think you need this.  We pull in all of third_party in the last rule
before deps_os =.


More information about the webkit-reviews mailing list