[webkit-reviews] review granted: [Bug 110519] Object allocation profiling will refuse to create objects with more than JSFinalObject::maxInlineCapacity() inline slots, but JSFunction::allocationProfile() asserts that the number of inline slots is always what it asked for : [Attachment 189608] tbhe patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 15:10:48 PST 2013


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 110519: Object allocation profiling will refuse to create objects with more
than JSFinalObject::maxInlineCapacity() inline slots, but
JSFunction::allocationProfile() asserts that the number of inline slots is
always what it asked for
https://bugs.webkit.org/show_bug.cgi?id=110519

Attachment 189608: tbhe patch
https://bugs.webkit.org/attachment.cgi?id=189608&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

Would be nice to rename the argument to inferredInlineCapacity, too. The
convention is that "inlineCapacity" means the real number, and not the guess.


More information about the webkit-reviews mailing list