[webkit-reviews] review denied: [Bug 110447] REGRESSION(r143470): editing/spelling/spelling-changed-text.html fails on Qt, GTK, EFL : [Attachment 189577] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Rouslan Solomakhin
<rouslan+webkit at chromium.org>'s request for review:
Bug 110447: REGRESSION(r143470): editing/spelling/spelling-changed-text.html
fails on Qt, GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=110447

Attachment 189577: Patch
https://bugs.webkit.org/attachment.cgi?id=189577&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189577&action=review


> LayoutTests/platform/efl/TestExpectations:1865
> +# Need to add "cheher" misspelling to tests.
> +webkit.org/b/110503 editing/spelling/spelling-changed-text.html [ Skip ]

Looks like we should use Failure since it's not timing out on EFL:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/51
37/steps/layout-test/logs/stdio

The benefit of Failure is you can see the diff on the waterfall:
http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20(Tests)/
r143631%20(4487)/editing/spelling/spelling-changed-text-pretty-diff.html

Looks like there's some testRunner method that isn't implemented.

> LayoutTests/platform/gtk/TestExpectations:1446
> +# Need to add "cheher" misspelling to tests.
> +webkit.org/b/110501 editing/spelling/spelling-changed-text.html [ Skip ]

This one also looks like Failure:
http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20WK2%20%28Test
s%29/builds/4487/steps/layout-test/logs/stdio