[webkit-reviews] review denied: [Bug 110487] Ctrl+Shift+Right in Windows should select the spacing after the word : [Attachment 189549] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 11:10:30 PST 2013


Tony Chang <tony at chromium.org> has denied Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 110487: Ctrl+Shift+Right in Windows should select the spacing after the
word
https://bugs.webkit.org/show_bug.cgi?id=110487

Attachment 189549: Patch
https://bugs.webkit.org/attachment.cgi?id=189549&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189549&action=review


r- due to lack of tests and failing tests.  Why did this change the results of
a test on Linux?

> Source/WebCore/editing/FrameSelection.cpp:603
> +#if USE(ICU_UNICODE)

Why does this depend on ICU_UNICODE?


More information about the webkit-reviews mailing list