[webkit-reviews] review canceled: [Bug 110412] Building for WinCE (cmake) x86 targets fail : [Attachment 189429] Proposed fix

[bugzilla-daemon at webkit.org]

Mark Salisbury <mark.salisbury at hp.com> has canceled Mark Salisbury
<mark.salisbury at hp.com>'s request for review:
Bug 110412: Building for WinCE (cmake) x86 targets fail
https://bugs.webkit.org/show_bug.cgi?id=110412

Attachment 189429: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=189429&action=review

------- Additional Comments from Mark Salisbury <mark.salisbury at hp.com>
Unfortunately, none of the ARM architecture defines besides just "_ARM_" and
"ARM" are set (this is either a problem with my platform SDK or with CMake), so
it is necessary to define either WTF_CPU_ARM_THUMB2 or WTF_CPU_ARM_TRADITIONAL
in OptionsWinCE.cmake when building for ARM.  I'm not the only one with this
issue (as WTF_CPU_ARM_TRADITIONAL is defined now in OptionsWinCE.cmake).

With this patch, you can build for x86 and you can build for ARM.  If you
choose, when you run CMake you can specify what your ARM architecture version
is and if you have THUMB2 support.  I tried both of these, since I'm actually
targeting a Cortex A8 CPU (ARM architecture v7).  When I did this I discovered
some other issues that will need to be addressed later to enable ARM v7
architecture on WinCE.	If you don't specify the ARM architecture version or
THUMB2 support, then you get WTF_CPU_ARM_TRADITIONAL defined (same as we have
now) which does build successfully.