[webkit-reviews] review denied: [Bug 109560] Implement coordinated scrollbar for subframes and sublayers : [Attachment 189465] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 10:27:51 PST 2013


James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 109560: Implement coordinated scrollbar for subframes and sublayers
https://bugs.webkit.org/show_bug.cgi?id=109560

Attachment 189465: Patch
https://bugs.webkit.org/attachment.cgi?id=189465&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189465&action=review


> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:165
> +#if OS(ANDROID)
> +	   bool platformSupported = true;
> +#else
> +	   bool platformSupported = false;
> +#endif

This is way too heavy handed and will be a big performance regression on other
platforms.


More information about the webkit-reviews mailing list