[webkit-reviews] review granted: [Bug 108835] Optimize GlyphPage for case where all glyphs are available in the same font. : [Attachment 189517] Mildly desperate patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 108835: Optimize GlyphPage for case where all glyphs are available in the
same font.
https://bugs.webkit.org/show_bug.cgi?id=108835

Attachment 189517: Mildly desperate patch
https://bugs.webkit.org/attachment.cgi?id=189517&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=189517&action=review


Nice, r=me

> Source/WebCore/platform/graphics/GlyphPage.h:59
> +#if COMPILER(MSVC)
> +#pragma warning(push)
> +#pragma warning(disable: 4200) // Disable "zero-sized array in struct/union"
warning
> +#endif

Could this silly warning be disabled globally?

> Source/WebCore/platform/graphics/GlyphPage.h:158
> +	   // This method should only be called on the system fallback page,
which is never single-font.
> +	   ASSERT(hasPerGlyphFontData());

Maybe add "system fallback page" to the function name?