[webkit-reviews] review granted: [Bug 100754] Faster sorting of numeric arrays : [Attachment 188192] Patch and tests

[bugzilla-daemon at webkit.org]

Yong Li <yoli at rim.com> has granted Cosmin Truta <ctruta at gmail.com>'s request
for review:
Bug 100754: Faster sorting of numeric arrays
https://bugs.webkit.org/show_bug.cgi?id=100754

Attachment 188192: Patch and tests
https://bugs.webkit.org/attachment.cgi?id=188192&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188192&action=review


LGTM basically. Changes suggested by previous reviewers are addressed. But see
my comment.

> Source/JavaScriptCore/bytecode/ComparatorKind.h:35
> +enum ComparatorKind {
> +    CustomComparator,
> +    NumericAscendingComparator,
> +    NumericDescendingComparator
> +};

This enum will be folded into a 2-bit bit-field. It would be nice to add some
comments or compile time assert just in case someone inserts more enum values
but doesn't check the bit-field accordingly.