[webkit-reviews] review granted: [Bug 110293] [GTK] Move feature overriding to the configure phase : [Attachment 189251] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 21 04:23:36 PST 2013
Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 110293: [GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293
Attachment 189251: Patch
https://bugs.webkit.org/attachment.cgi?id=189251&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189251&action=review
LGTM!
> Source/autotools/SetupWebKitFeatures.m4:189
> + dnl Grep the generated GNUmakefile.features.am
s/GNUmakefile.features.am/WebKitFeatures.txt/, but I'd just remove the comment,
the code is pretty self-explanatory.
More information about the webkit-reviews
mailing list