[webkit-reviews] review denied: [Bug 110397] Allow to override previously declined or accepted Geolocation permission : [Attachment 189397] Allow overriding the WebGeolocationPermission of frames

[bugzilla-daemon at webkit.org]

jochen at chromium.org has denied Dominic Battre <battre at chromium.org>'s request
for review:
Bug 110397: Allow to override previously declined or accepted Geolocation
permission
https://bugs.webkit.org/show_bug.cgi?id=110397

Attachment 189397: Allow overriding the WebGeolocationPermission of frames
https://bugs.webkit.org/attachment.cgi?id=189397&action=review

------- Additional Comments from jochen at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=189397&action=review


You patch lacks a changelog?

> Source/WebKit/chromium/public/WebGeolocationPermissionRequest.h:50
> +    WEBKIT_EXPORT static void setIsAllowed(WebFrame*, bool allowed);

putting this on WebGeolocationPermissionRequest seems wrong. I'd make this a
method on WebGeolocationController and add a method to GeolocationController
that lets you update all of its observers.

> Source/WebKit/chromium/src/WebGeolocationPermissionRequest.cpp:55
> +// static

we normally don't use // static