[webkit-reviews] review granted: [Bug 110415] Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window : [Attachment 189444] new names

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 110415: Provide WKView SPI to defer telling the WebPageProxy and WebProcess
about changes in the hosting window
https://bugs.webkit.org/show_bug.cgi?id=110415

Attachment 189444: new names
https://bugs.webkit.org/attachment.cgi?id=189444&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189444&action=review


> Source/WebKit2/UIProcess/API/mac/WKView.mm:213
> +    BOOL _windowChangeWasDeferred;

Want to rename this to 'viewInWindowChangeWasDeferred'?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3306
> +    if (!(--_data->_viewInWindowChangesDeferredCount) &&
_data->_windowChangeWasDeferred) {

Would be clearer to just hoist the --_data->_viewInWindowChangesDeferredCount
outside the condition.