[webkit-reviews] review denied: [Bug 110415] Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window : [Attachment 189425] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 110415: Provide WKView SPI to defer telling the WebPageProxy and WebProcess
about changes in the hosting window
https://bugs.webkit.org/show_bug.cgi?id=110415

Attachment 189425: patch
https://bugs.webkit.org/attachment.cgi?id=189425&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189425&action=review


Let's try some new names.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:211
> +    unsigned _windowChangesDeferredCount;

viewInWindowDeferredCount?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1907
> +	   if ([self windowChangesDeferred]) {
> +	       _data->_page->viewStateDidChange(WebPageProxy::ViewIsVisible);
> +	       _data->_windowChangeWasDeferred = YES;

The naming makes this confusing. It's easy to think that -windowChangesDeferred
would return data->_windowChangeWasDeferred.

> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:60
> +- (BOOL)windowChangesDeferred;

How about:

-beginDeferringViewInWindowChanges
-endDeferringViewInWindowChanges
-shouldDeferViewInWindowChanges