[webkit-reviews] review denied: [Bug 110294] Out-of-view fixed position check should not be affected by page scale at all on Mac : [Attachment 189389] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 110294: Out-of-view fixed position check should not be affected by page
scale at all on Mac
https://bugs.webkit.org/show_bug.cgi?id=110294

Attachment 189389: Patch
https://bugs.webkit.org/attachment.cgi?id=189389&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189389&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:2107
> +#if PLATFORM(CHROMIUM)
>	   layerBounds.scale(frameView->frame()->frameScaleFactor());
> +#endif

I'm not a fan of this #ifdef. If there's a real behavior change between
platforms, it should either be a runtime-testable thing, or some meaningful
#ifdef.