[webkit-reviews] review granted: [Bug 110392] [New Multicolumn] Fix overflow computation for column blocks : [Attachment 189390] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 110392: [New Multicolumn] Fix overflow computation for column blocks
https://bugs.webkit.org/show_bug.cgi?id=110392

Attachment 189390: Patch
https://bugs.webkit.org/attachment.cgi?id=189390&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189390&action=review


> Source/WebCore/rendering/RenderRegion.h:143
> +    virtual bool shouldHaveAutoLogicalHeight() const
>      {
>	   bool hasSpecifiedEndpointsForHeight =
style()->logicalTop().isSpecified() && style()->logicalBottom().isSpecified();
>	   bool hasAnchoredEndpointsForHeight = isOutOfFlowPositioned() &&
hasSpecifiedEndpointsForHeight;
>	   return style()->logicalHeight().isAuto() &&
!hasAnchoredEndpointsForHeight;
>      }

This should not be in the header now that it's virtual.