[webkit-reviews] review granted: [Bug 110389] Incorrect rendering for flex boxes with percentage height in a table cell : [Attachment 189399] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Christian Biesinger
<cbiesinger at chromium.org>'s request for review:
Bug 110389: Incorrect rendering for flex boxes with percentage height in a
table cell
https://bugs.webkit.org/show_bug.cgi?id=110389

Attachment 189399: Patch
https://bugs.webkit.org/attachment.cgi?id=189399&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189399&action=review


>
LayoutTests/css3/flexbox/flex-percentage-height-in-table-standards-mode.html:5
> +    #newflex { display: -webkit-flex; display: flex; height: 75%; }

Please use LayoutTests/css3/flexbox/resources/flexbox.css for the new flexbox
display value.	It let's us add -ms or other vendor prefixed values going
forward.

>
LayoutTests/css3/flexbox/flex-percentage-height-in-table-standards-mode.html:11

> +

It would be nice to have some text explaining what you should see.

> LayoutTests/css3/flexbox/flex-percentage-height-in-table.html:5
> +    #newflex { display: -webkit-flex; display: flex; height: 75%; }

Same comments apply to this test too.