[webkit-reviews] review granted: [Bug 110379] Zoomed, slow-scrolling pages keep recreating tiles when scrolled : [Attachment 189374] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 110379: Zoomed, slow-scrolling pages keep recreating tiles when scrolled
https://bugs.webkit.org/show_bug.cgi?id=110379

Attachment 189374: Patch
https://bugs.webkit.org/attachment.cgi?id=189374&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189374&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1624
> +    fprintf(stderr, "tileArea is %f x %f\n", tileArea.width(),
tileArea.height());

Nah.

> LayoutTests/ChangeLog:10
> +	   This test now just has one tile, rather than four. The apparent
issue
> +	   with the integral tile cache coverage rect being smaller than the
visible rect
> +	   is a rounding issue with the tile cache coverage dumping.

This sentence reads strangely.