[webkit-reviews] review canceled: [Bug 110014] [GTK][WK2] Add seccomp filters support : [Attachment 189321] wip

[bugzilla-daemon at webkit.org]

Thiago Marcos P. Santos <tmpsantos at gmail.com> has canceled Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 110014: [GTK][WK2] Add seccomp filters support
https://bugs.webkit.org/show_bug.cgi?id=110014

Attachment 189321: wip
https://bugs.webkit.org/attachment.cgi?id=189321&action=review

------- Additional Comments from Thiago Marcos P. Santos <tmpsantos at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189321&action=review


>> Source/WebKit2/WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp:8
>> + *	  notice, this list of conditions and the following disclaimer.
> 
> Is there anything GTK+ specific about this file or could it be shared with
EFL?

The policies shared by EFL, GTK and Qt are being added by
addDefaultWebProcessPolicy (see bug 89875). Because of the device APIs we have
on EFL by default (battery, network status, vibration, etc), I had to add some
extra policies specific to EFL. Qt has a few unique policies for fonts and
non-default Qt libraries path.

The trend is to fine tune policies according to features each port support and
enable over time.  

This patch is just an stub to show the amount of code need by GTK for enabling
this sandbox. If there is interest from the WebKit GTK project on this sandbox,
the next step would be try to run the layout tests and see what directories and
files are missing from the policies.