[webkit-reviews] review denied: [Bug 110323] UI side scroll API for Coordinated Graphics. : [Attachment 189284] WIP

[bugzilla-daemon at webkit.org]

Luiz Agostini <luiz at webkit.org> has denied  review:
Bug 110323: UI side scroll API for Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=110323

Attachment 189284: WIP
https://bugs.webkit.org/attachment.cgi?id=189284&action=review

------- Additional Comments from Luiz Agostini <luiz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189284&action=review


We are working on a Coordinated Graphics API test infrastructure as well. I
plan to add tests for this API as soon as it is ready.
There are some parts of this patch that make changes in code that can only be
found in NIX repository. They will of course be removed on the final patch. For
now they might help on showing how to use the API.
This patch is very raw. There is a lot to be improved. I will have a better
version soon.

> Source/WebCore/rendering/RenderLayer.cpp:522
> +//	     &&
renderer()->frame()->page()->settings()->acceleratedCompositingForOverflowScrol
lEnabled();

please ignore this code. It is just for testing.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:864
> +void CoordinatedLayerTreeHost::scrollingLayerWasAdded(uint32_t layerId)
> +{
> +   
m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::ScrollingLayerWasAdded
(layerId));
> +}
> +
> +void CoordinatedLayerTreeHost::scrollingLayerWasRemoved(uint32_t layerId)
> +{
> +   
m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::ScrollingLayerWasRemov
ed(layerId));
> +}

To use the CoordinatedLayerInfo to pass this information would be a lot more
efficient. It would remove a lot of code as well.