[webkit-reviews] review canceled: [Bug 109946] [Chromium] Add support for emulating legacy Android WebView 'setInitialScale' method : [Attachment 188868] Comments addressed

[bugzilla-daemon at webkit.org]

Mikhail Naganov <mnaganov at chromium.org> has canceled Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 109946: [Chromium] Add support for emulating legacy Android WebView
'setInitialScale' method
https://bugs.webkit.org/show_bug.cgi?id=109946

Attachment 188868: Comments addressed
https://bugs.webkit.org/attachment.cgi?id=188868&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
Alexandre, please take a look.

I had a trouble calling computePageScaleFactorLimits when having viewport
disabled, because computePageScaleFactorLimits expects
m_pageDefined*ScaleFactor to be set. As you have mentioned, you are inclined to
remove setPageScaleFactorLimits, so I went ahead and made
computePageScaleFactorLimits to work without them, this doesn't seem to break
anything.