[webkit-reviews] review granted: [Bug 110037] Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler. : [Attachment 189260] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 01:19:59 PST 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Mike West <mkwst at chromium.org>'s
request for review:
Bug 110037: Use EventPathWalker rather than parentNode() to normalize event
targets in EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=110037

Attachment 189260: Patch
https://bugs.webkit.org/attachment.cgi?id=189260&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189260&action=review


> Source/WebCore/page/EventHandler.cpp:711
> +	   renderer = parent ? parent->renderer() : 0;

I would have preferred to see an early return when parent was 0.


More information about the webkit-reviews mailing list