[webkit-reviews] review denied: [Bug 110269] Optionally partition cache to prevent using cache for tracking : [Attachment 189189] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 110269: Optionally partition cache to prevent using cache for tracking
https://bugs.webkit.org/show_bug.cgi?id=110269

Attachment 189189: Patch
https://bugs.webkit.org/attachment.cgi?id=189189&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189189&action=review


Please add an ifdef so that ports that don't want to partition the MemoryCache
do not need to compile in code for partitioning the memory cache.

> Source/WebCore/loader/cache/MemoryCache.cpp:69
> +#if PLATFORM(MAC)

This is the wrong ifdef to use here.  We should instead have a USE or ENABLE
macro for the public suffix list.

> Source/WebCore/platform/PublicSuffix.h:33
> +bool isPublicSuffix(const String& domain);

Please put this header behind a USE or ENABLE ifdef so that ports that don't
wish to depend on the public suffix list do not need to.

> Source/WebCore/platform/network/ResourceRequestBase.h:194
> +	   String m_cachePartition;

It's not appropriate to add apple-mac specific state to ResourceRequestBase. 
Please add it to ResourceRequestMac instead.