[webkit-reviews] review denied: [Bug 110276] Fix crash in preloading scanning base tags with no href attribute for background parser : [Attachment 189193] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 16:10:15 PST 2013


Adam Barth <abarth at webkit.org> has denied  review:
Bug 110276: Fix crash in preloading scanning base tags with no href attribute
for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276

Attachment 189193: Patch
https://bugs.webkit.org/attachment.cgi?id=189193&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189193&action=review


> Source/WebCore/html/parser/CompactHTMLToken.h:86
> +    Vector<Attribute> m_attributes;

Attribute contains AtomicString and QualifiedName, which means it's not save to
move between threads.


More information about the webkit-reviews mailing list