[webkit-reviews] review granted: [Bug 110273] webdatabase: Introduce AbstractSQLTransaction and AbstractSQLTransactionBackend : [Attachment 189191] the patch.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 110273: webdatabase: Introduce AbstractSQLTransaction and
AbstractSQLTransactionBackend
https://bugs.webkit.org/show_bug.cgi?id=110273

Attachment 189191: the patch.
https://bugs.webkit.org/attachment.cgi?id=189191&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189191&action=review


> Source/WebCore/Modules/webdatabase/SQLTransaction.h:79
> +    virtual void requestTransitToState(SQLTransactionState);
> +    virtual bool hasCallback() const;
> +    virtual bool hasSuccessCallback() const;
> +    virtual bool hasErrorCallback() const;
> +    virtual void setBackend(AbstractSQLTransactionBackend*);

You should add OVERRIDE to these.

> Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h:84
> +    virtual void requestTransitToState(SQLTransactionState);
> +    virtual PassRefPtr<SQLError> transactionError();
> +    virtual AbstractSQLStatement* currentStatement();
> +    virtual void setShouldRetryCurrentStatement(bool);
> +    virtual void executeSQL(PassOwnPtr<AbstractSQLStatement>, const String&
statement,
> +	   const Vector<SQLValue>& arguments, int permissions);

And here.