[webkit-reviews] review granted: [Bug 110268] StorageAreaProxy should know its quota : [Attachment 189178] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 15:14:43 PST 2013


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 110268: StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268

Attachment 189178: Patch
https://bugs.webkit.org/attachment.cgi?id=189178&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189178&action=review


> Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp:97
> +    exceptionCode = 0;

I think we usually call this ec.

> Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h:58
> +    unsigned m_quota;

What units is this in terms of.  Please either add a comment or make the name
more descriptive.


More information about the webkit-reviews mailing list