[webkit-reviews] review granted: [Bug 110239] [New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing : [Attachment 189165] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 110239: [New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the
RenderRegion -> RenderBlock subclassing
https://bugs.webkit.org/show_bug.cgi?id=110239

Attachment 189165: Patch
https://bugs.webkit.org/attachment.cgi?id=189165&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=189165&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:254
> +    // layout code that attempts to pixel snap will be incorrect. In general
this is a huge problem with
> +    // subpixel layout (that attempts at snapping are just utterly wrong in
the presence of any non-integral

Perhaps you could omit this or say it in a more forward-looking way.