[webkit-reviews] review denied: [Bug 109421] [WK2][EFL][Qt] Viewport size is affected on page reload. : [Attachment 188559] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 14:24:48 PST 2013


Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 109421: [WK2][EFL][Qt] Viewport size is affected on page reload.
https://bugs.webkit.org/show_bug.cgi?id=109421

Attachment 188559: patch v3
https://bugs.webkit.org/attachment.cgi?id=188559&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188559&action=review


1) Why no test?
2) Despite the ChangeLog, I really don't understand why would the drawing area
know anything about didCommitLoadForFrame. This looks like punching a giant
hole through layers.

> Source/WebKit2/ChangeLog:10
> +	   but CoordinatedLayerTreeHostProxy did not send anything in case if
the

"in case if the"?


More information about the webkit-reviews mailing list