[webkit-reviews] review granted: [Bug 109980] [WK2] Calls to WKPageLoadURL() when WebProcess was terminated may fail : [Attachment 189135] Changes: comments, empty line, no longer using gtest magick.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Adenilson Cavalcanti Silva
<savagobr at yahoo.com>'s request for review:
Bug 109980: [WK2] Calls to WKPageLoadURL() when WebProcess was terminated may
fail
https://bugs.webkit.org/show_bug.cgi?id=109980

Attachment 189135: Changes: comments, empty line, no longer using gtest magick.
https://bugs.webkit.org/attachment.cgi?id=189135&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189135&action=review


> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:92
> +// First test will load a blank page and next kill WebProcess, the expected
> +// result is that a call to page load should spawn a new WebProcess.

You should say "This test" instead of "First test".
Rationale:
-If someone add a test in this file, the comments get out of date.
-We should not imply there is an order of testing. Testing the test in any
order should be the same.

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:103
> +// Crash handler, used only by the second test.

"the second test" -> LoadPageInCrashHandler

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:108
> +    // In the second test, we try to load from the crash handler.

ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:113
> +// This is similar to the first test (i.e. we will load a page and

"the first test"->LoadPageAfterCrash