[webkit-reviews] review granted: [Bug 110045] [WebGL] Fix oes-element-index-uint.html test. : [Attachment 188752] patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 110045: [WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045

Attachment 188752: patch
https://bugs.webkit.org/attachment.cgi?id=188752&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188752&action=review


It looks like this test is currently broken so yes, let's fix it. However, the
better long-term fix is Gregg's incorporation of the WebGL conformance tests as
layout tests, which has been recently completed. Would be good if you could
devote effort to getting those tests turned on on various ports. r=me

> LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:99
> +    var program = wtu.setupSimpleTextureProgram(gl);

It looks like the only reason for this change is that
resources/webgl-test-utils is out of date. Is that correct?

> LayoutTests/fast/canvas/webgl/oes-element-index-uint.html:285
> +    gl.disableVertexAttribArray(vertexLoc);

It looks like a recent upstream fix to webgl-test-utils removes the need for
this. Can you test with
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/oes-ele
ment-index-uint.html and confirm?