[webkit-reviews] review granted: [Bug 110244] [CSS Grid Layout] Refactor the code in preparation of auto placement support : [Attachment 189130] Proposed refactoring 2: Including some simple tests for grid-auto-flow: none, more testing with the real algorithm.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 110244: [CSS Grid Layout] Refactor the code in preparation of auto
placement support
https://bugs.webkit.org/show_bug.cgi?id=110244

Attachment 189130: Proposed refactoring 2: Including some simple tests for
grid-auto-flow: none, more testing with the real algorithm.
https://bugs.webkit.org/attachment.cgi?id=189130&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189130&action=review


Please fix the test issue before submitting. Otherwise, this looks good.

> LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html:21
> +	   <div class="sizedToGridArea autoRowAutoColumn"
data-expected-width="50" data-expected-height="50">XXXXX XXXXX XXXXX</div>

Shouldn't this be checking x/y offsets if the thing we're checking is the
positioning?