[webkit-reviews] review denied: [Bug 110064] Let JS wrapper manage Attr node lifetime instead of Element. : [Attachment 188944] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 19 10:41:43 PST 2013
Adam Barth <abarth at webkit.org> has denied Andreas Kling <akling at apple.com>'s
request for review:
Bug 110064: Let JS wrapper manage Attr node lifetime instead of Element.
https://bugs.webkit.org/show_bug.cgi?id=110064
Attachment 188944: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=188944&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Doesn't this mess up the DOM semantics? Support JavaScript has a reference to
the Attr and no other references to Nodes. Now a GC will delete the wrapper
from the Attr's ownerElement, which will be observable.
More information about the webkit-reviews
mailing list