[webkit-reviews] review granted: [Bug 110206] [v8] ScriptValue has dangerous copy semantics : [Attachment 189072] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Dan Carney
<dcarney at google.com>'s request for review:
Bug 110206: [v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206

Attachment 189072: Patch
https://bugs.webkit.org/attachment.cgi?id=189072&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189072&action=review


Understood. Let's kill v8ValueRaw() in a follow-up.

> Source/WebCore/ChangeLog:9
> +	   Update ScriptValue to use a reference counted ScopedPersistent
> +	   as the existing implementation makes it easy to return dead
references.

Update the ChangeLog.

> Source/WebCore/bindings/v8/ScriptValue.h:138
> +    v8::Handle<v8::Value> v8ValueRaw() const

Please add FIXME to indicate that v8ValueRaw() should be deprecated.