[webkit-reviews] review denied: [Bug 110224] Web Inspector: View.markAsRoot should never be invoked on attached view. : [Attachment 189087] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 19 07:32:39 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 110224: Web Inspector: View.markAsRoot should never be invoked on attached
view.
https://bugs.webkit.org/show_bug.cgi?id=110224
Attachment 189087: Patch
https://bugs.webkit.org/attachment.cgi?id=189087&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189087&action=review
> Source/WebCore/inspector/front-end/Drawer.js:89
> + this._view.detach();
Please add a test.
More information about the webkit-reviews
mailing list