[webkit-reviews] review denied: [Bug 110156] Web Inspector: show source location after drawer views : [Attachment 188987] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 06:19:20 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 110156: Web Inspector: show source location after drawer views
https://bugs.webkit.org/show_bug.cgi?id=110156

Attachment 188987: Patch
https://bugs.webkit.org/attachment.cgi?id=188987&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188987&action=review


> Source/WebCore/inspector/front-end/Panel.js:74
> +	   panelStatusBar.appendChild(drawerViewAnchor);

You will end up with a lot of these.

> Source/WebCore/inspector/front-end/inspector.js:133
> +	   var element =
panelStatusBar.getElementsByClassName("drawer-view-anchor")[0];

It is bad to depend on the class that was added by a component.


More information about the webkit-reviews mailing list