[webkit-reviews] review granted: [Bug 110124] Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node : [Attachment 188895] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 110124: Web Inspector: Native Memory Instrumentation: show user provided
name property of the heap snapshot node
https://bugs.webkit.org/show_bug.cgi?id=110124

Attachment 188895: Patch
https://bugs.webkit.org/attachment.cgi?id=188895&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188895&action=review


> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186
> +    this._worker = /*typeof InspectorTest === "undefined" ? new
WebInspector.HeapSnapshotRealWorker() :*/ new
WebInspector.HeapSnapshotFakeWorker();

Please revert this.

> Source/WebCore/inspector/front-end/NativeHeapSnapshot.js:112
> +	       userProvidedName: this.name(),

displayName ?