[webkit-reviews] review granted: [Bug 110168] Begin stubbing out session storage classes : [Attachment 188964] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 110168: Begin stubbing out session storage classes
https://bugs.webkit.org/show_bug.cgi?id=110168

Attachment 188964: Patch
https://bugs.webkit.org/attachment.cgi?id=188964&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188964&action=review


LGTM

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:72
> +    HashMap<RefPtr<SecurityOrigin>, RefPtr<StorageArea>, SecurityOriginHash>
m_storageAreaMap;

Can we make a global DefaultHash<RefPtr<SecurityOrigin> > that pulls in
SecurityOriginHash?
That could clean up a number of usage sites. Not necessary for this patch.