[webkit-reviews] review canceled: [Bug 110064] Let JS wrapper manage Attr node lifetime instead of Element. : [Attachment 188782] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 14:37:58 PST 2013


Andreas Kling <akling at apple.com> has canceled Andreas Kling
<akling at apple.com>'s request for review:
Bug 110064: Let JS wrapper manage Attr node lifetime instead of Element.
https://bugs.webkit.org/show_bug.cgi?id=110064

Attachment 188782: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=188782&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
- Bit more fleshy ChangeLog.
- Removed detaching of Attr nodes in ~Element() since Element won't be
destroyed as long as Attr nodes are attached.
- Added a comment about Attr::ownerElement() being named that way because of
DOM API.


More information about the webkit-reviews mailing list