[webkit-reviews] review granted: [Bug 110104] Web Inspector: Native Memory Instrumentation: Generate meta information for HeapSnapshot parser : [Attachment 188852] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 110104: Web Inspector: Native Memory Instrumentation: Generate meta
information for HeapSnapshot parser
https://bugs.webkit.org/show_bug.cgi?id=110104

Attachment 188852: Patch
https://bugs.webkit.org/attachment.cgi?id=188852&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188852&action=review


> Source/WebCore/inspector/HeapGraphSerializer.cpp:64
> +    // FIXME: It is using as a magic constant for 'object' node type.

It is using -> It is used

> Source/WebCore/inspector/HeapGraphSerializer.cpp:175
> +		   "[],"

Please add a comment here that we are trying to use the same array of strings
as for other values instead of providing a predefined enum of types.

> Source/WebCore/inspector/HeapGraphSerializer.cpp:225
> +    m_typeStrings->setNumber(string, stringId);

This map is redundant we could store something like array of type ids instead.

> Source/WebCore/inspector/Inspector.json:81
> +		       { "name": "graphMetaInformation", "type": "object",
"description": "An object describing a meta information about the heap graph."}


"An object describing structures of nodes and edges in the graph."

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1034
> +		       console.log(JSON.stringify(dumpNode.serialize()));

Please add some indentation for the formatted JSON string.