[webkit-reviews] review denied: [Bug 110095] Web Inspector: Refactorings: extract _localize to improve typing. : [Attachment 188846] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 110095: Web Inspector: Refactorings: extract _localize to improve typing.
https://bugs.webkit.org/show_bug.cgi?id=110095

Attachment 188846: Patch
https://bugs.webkit.org/attachment.cgi?id=188846&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188846&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:554
> +			   console.error(WebInspector.UIString("Unknown scope
type: \"%s\"", scope.type));

Why is this a part of the change?

> Source/WebCore/inspector/front-end/UIString.js:59
> +    return String.vsprintf(WebInspector._localize(string),
Array.prototype.slice.call(arguments, 1));

Why do you extract it?