[webkit-reviews] review denied: [Bug 110095] Web Inspector: Refactorings: extract utils for DOM building. : [Attachment 188825] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 18 02:22:04 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 110095: Web Inspector: Refactorings: extract utils for DOM building.
https://bugs.webkit.org/show_bug.cgi?id=110095
Attachment 188825: Patch
https://bugs.webkit.org/attachment.cgi?id=188825&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188825&action=review
> Source/WebCore/inspector/front-end/UIString.js:36
> +WebInspector.localize = function(string) {
Should be private.
> Source/WebCore/inspector/front-end/UIUtils.js:1106
> +WebInspector.formatFragment = function(format, substitutions, formatters) {
{ on the next line.
If that is extracted, where is the updated client?
More information about the webkit-reviews
mailing list