[webkit-reviews] review granted: [Bug 110061] AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase : [Attachment 188775] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 17 18:33:19 PST 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 110061: AX: rename WebAccessibilityObjectWrapper to
WebAccessibilityObjectWrapperBase
https://bugs.webkit.org/show_bug.cgi?id=110061

Attachment 188775: patch
https://bugs.webkit.org/attachment.cgi?id=188775&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188775&action=review


r=me as long as you don't rename WebAccessibilityObjectWrapperMac.{h|mm} to
remove "Mac" from the name.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm:30
> -#import "WebAccessibilityObjectWrapperMac.h"
> +#import "WebAccessibilityObjectWrapper.h"

Please leave these files named as WebAccessibilityObjectWrapperMac.{h|mm} even
though the class is named "WebAccessibilityObjectWrapper" so that it's easier
to know which implementation is being included or compiled.


More information about the webkit-reviews mailing list