[webkit-reviews] review denied: [Bug 29084] getComputedStyle returns percentage values for left / right / top / bottom : [Attachment 188785] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 29084: getComputedStyle returns percentage values for left / right / top /
bottom
https://bugs.webkit.org/show_bug.cgi?id=29084

Attachment 188785: Patch
https://bugs.webkit.org/attachment.cgi?id=188785&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188785&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

We definitely need a new layout test for this. r- due to lack of tests.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:669
> +		   maxWidth = renderer->containingBlock()->availableWidth();
> +		   break;
> +	       case CSSPropertyTop:
> +	       case CSSPropertyBottom:
> +		   maxWidth = renderer->containingBlock()->availableHeight();

Does this work in vertical writing mode? We need a test.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:672
> +	       default: {
> +	       }}

Please replace {} with a break.