[webkit-reviews] review granted: [Bug 109765] Reschedule shared CFRunLoopTimer instead of reconstructing it : [Attachment 188716] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 17 14:23:30 PST 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 109765: Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765
Attachment 188716: patch2
https://bugs.webkit.org/attachment.cgi?id=188716&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188716&action=review
r=me if you find a nicer color for the bikeshed.
> Source/WebCore/platform/mac/SharedTimerMac.mm:171
> +void reinsertSharedTimer()
I'd just prefer to call this removeFoo() instead of reinsertBar() since that's
what it does.
More information about the webkit-reviews
mailing list