[webkit-reviews] review canceled: [Bug 108598] [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API : [Attachment 188648] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has canceled Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 108598: [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal
C++ API
https://bugs.webkit.org/show_bug.cgi?id=108598

Attachment 188648: Patch
https://bugs.webkit.org/attachment.cgi?id=188648&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188648&action=review


>> Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.h:51
>>   * Retrieves asynchronously from the database the favicon for the given @a
page_url
> 
> Should this be synchronous instead ?

Right, good catch.