[webkit-reviews] review denied: [Bug 82791] Add support for new canvas ellipse method : [Attachment 152438] patch v.4

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 82791: Add support for new canvas ellipse method
https://bugs.webkit.org/show_bug.cgi?id=82791

Attachment 152438: patch v.4
https://bugs.webkit.org/attachment.cgi?id=152438&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152438&action=review


The patch looks good to me. It won't apply to trunk so. Please update the patch
for a new review.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:925
> +void CanvasRenderingContext2D::ellipse(float x, float y, float rX, float rY,
float rot, float sa, float ea, bool anticlockwise, ExceptionCode& ec)

just rx and ry. No capitalized letters.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:945
> +    // If 'sa' and 'ea' differ by more than 2Pi, just add a circle
starting/ending at 'sa'

Do we do the same on arc? We shouldn't differ here.