[webkit-reviews] review granted: [Bug 101243] Add an SVG content model test : [Attachment 173646] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 15 23:46:16 PST 2013
Dirk Schulze <krit at webkit.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 101243: Add an SVG content model test
https://bugs.webkit.org/show_bug.cgi?id=101243
Attachment 173646: Patch
https://bugs.webkit.org/attachment.cgi?id=173646&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173646&action=review
>> LayoutTests/svg/dom/resources/svgtags.js:28
>> + feDiffuseLighting: { needParent: 'filter', needChld: [
'fePointLight' ] },
>
> This and other element descriptions are not complete. Can you add a FIXME
that points that out, or make it complete please? Other then that, looks great.
A short note that this should be extended at the beginning might be enough.
r=me.
More information about the webkit-reviews
mailing list