[webkit-reviews] review granted: [Bug 109983] Enhance AudioBus copyFrom() and sumFrom() to be able to handle discrete and speakers up and down-mixing : [Attachment 188666] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 109983: Enhance AudioBus copyFrom() and sumFrom() to be able to handle
discrete and speakers up and down-mixing
https://bugs.webkit.org/show_bug.cgi?id=109983

Attachment 188666: Patch
https://bugs.webkit.org/attachment.cgi?id=188666&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188666&action=review


Code looks reasonable to me. One question.

> Source/WebCore/platform/audio/AudioBus.cpp:373
>	       channel(i)->sumFrom(sourceBus.channel(i));

Is anything else supposed to happen here? For example, zeroing the remaining
destination channels?