[webkit-reviews] review granted: [Bug 109960] [GTK] Spread the gyp build files throughout the tree : [Attachment 188632] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 109960: [GTK] Spread the gyp build files throughout the tree
https://bugs.webkit.org/show_bug.cgi?id=109960

Attachment 188632: Patch
https://bugs.webkit.org/attachment.cgi?id=188632&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188632&action=review


looks basically fine. As I've mentioned before, I'm not a big fan of the
widespread use of relative paths in gyp, and so if I was doing this I'd keep
$(Source) around in some form and then derive all of the other variables
relative to that.

But I can't say for sure that that's definitely a better way to do things;
others might disagree.

> Source/JavaScriptCore/JavaScriptCore.gyp/generate-derived-sources.sh:14
> +make --no-builtin-rules -f "$JavaScriptCore/DerivedSources.make"
JavaScriptCore=$JavaScriptCore

hopefully at some point we can get away from needing to call make ...