[webkit-reviews] review canceled: [Bug 109769] EventHandler::handleGestureScrollUpdate() should not use RenderLayer::scrollBy() to perform scrolling : [Attachment 188663] Patch

[bugzilla-daemon at webkit.org]

Terry Anderson <tdanderson at chromium.org> has canceled Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 109769: EventHandler::handleGestureScrollUpdate() should not use
RenderLayer::scrollBy() to perform scrolling
https://bugs.webkit.org/show_bug.cgi?id=109769

Attachment 188663: Patch
https://bugs.webkit.org/attachment.cgi?id=188663&action=review

------- Additional Comments from Terry Anderson <tdanderson at chromium.org>
WIP, not for review.

This patch appears to work fine for propagated gesture scrolls (including
iframes). Fling gestures do not propagate; I was able to very nicely hook into
the existing logic in RenderBox::scroll() by passing in |stopNode|, which
eliminates the need for using the ScrollPropagation enum.

I have also reverted the changes I made to RenderLayer::scrollByRecursively()
in http://trac.webkit.org/changeset/140177 and
http://trac.webkit.org/changeset/142195 since this function will no longer be
used to gesture-scroll.

Left to do:
- Fix the layout tests. The propagation-specific ones are erroneously failing.
Manually running these tests verifies that they work.

Left to do (possibly in a follow-up patch):
- Refactoring to eliminate the more-or-less copied and pasted code in
FrameView::gestureScrollUpdateEvent(),
ScrollAnimator::handleGestureScrollUpdateEvent(), and
ScrollableArea::handleGestureScrollUpdateEvent().