[webkit-reviews] review granted: [Bug 109702] Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer. : [Attachment 188215] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 109702: Add a CDMClient class which allows the CDM to query for the
currently attached MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=109702

Attachment 188215: Patch
https://bugs.webkit.org/attachment.cgi?id=188215&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188215&action=review


> Source/WebCore/Modules/encryptedmedia/CDM.h:50
> +    virtual MediaPlayer* CDMMediaPlayer(CDM*) = 0;

The upper case "CDMMediaPlayer" seems odd, "cdmMediaPlayer" maybe? Also, can it
be const?

> Source/WebCore/Modules/encryptedmedia/CDM.h:76
> +    CDMClient* client() { return m_client; }

const?

> Source/WebCore/Modules/encryptedmedia/CDM.h:79
> +    MediaPlayer* mediaPlayer();

Ditto.

> Source/WebCore/Modules/encryptedmedia/MediaKeys.h:56
> +    HTMLMediaElement* mediaElement();

const.

Do you need to implement this?

> Source/WebCore/Modules/encryptedmedia/MediaKeys.h:61
> +    virtual MediaPlayer* CDMMediaPlayer(CDM*);

OVERRIDE.