[webkit-reviews] review granted: [Bug 109842] [WK2] Write a test to simulate crashed WebProcess followed by Window resize : [Attachment 188645] Data in a struct, hopefully XCode should be happy

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Adenilson Cavalcanti Silva
<savagobr at yahoo.com>'s request for review:
Bug 109842: [WK2] Write a test to simulate crashed WebProcess followed by
Window resize
https://bugs.webkit.org/show_bug.cgi?id=109842

Attachment 188645: Data in a struct, hopefully XCode should be happy
https://bugs.webkit.org/attachment.cgi?id=188645&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=188645&action=review


> Tools/TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:38
> +    : webView(context)
> +    , firstLoad(false)
> +    , resizeAfterCrash(false)

This would be indented 4 more spaces to the right in WebKit style.

> Tools/TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:50
> +	   // Loading a blank page worked, next we will kill WebProcess

Period at the end of the sentence.

> Tools/TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:69
> +    WKPageReload(page);

What cases does this cover?